[PATCH] D49221: DAG: Add calling convention argument to calling convention funcs

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 27 06:11:13 PDT 2018


nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

This makes sense to me. One nit-pick, apart from that LGTM.



================
Comment at: lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp:96-97
                 mf.getDataLayout());
-  CanLowerReturn = TLI->CanLowerReturn(Fn->getCallingConv(), *MF,
+  CanLowerReturn = TLI->CanLowerReturn(CC, *MF,
                                        Fn->isVarArg(), Outs, Fn->getContext());
 
----------------
This looks like clang-format would complain about it. Probably in some other places as well.


https://reviews.llvm.org/D49221





More information about the llvm-commits mailing list