[PATCH] D46754: [AMDGPU] Add intrinsics for 16 bit interpolation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.interp.f16.ll:1-3
+; RUN: llc -march=amdgcn -mcpu=gfx900 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX9_32BANK %s
+; RUN: llc -march=amdgcn -mcpu=fiji -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX8_32BANK %s
+; RUN: llc -march=amdgcn -mcpu=gfx810 -verify-machineinstrs < %s | FileCheck -check-prefixes=GFX8_16BANK %s
----------------
Use -'s instead of _'s in the check prefixes


================
Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.interp.f16.ll:5-7
+; GFX9_32BANK-LABEL: {{^}}interp_f16:
+; GFX9_32BANK: s_mov_b32 m0, s{{[0-9]+}}
+; GFX9_32BANK: v_interp_p1ll_f16{{(_e32)*}} v{{[0-9]+}}, v{{[0-9]+}}, attr2.y{{$}}
----------------
Might as well just use update_llc_test_checks at this point?


Repository:
  rL LLVM

https://reviews.llvm.org/D46754