[PATCH] D49887: [DebugInfo] Add basic support for DWARF5 call site-related attributes

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 21:36:44 PDT 2018


dblaikie added a comment.

Do you really want to implement all_calls? It seems like that's going to be difficult and expensive (in size). Looks like you're focussed  mostly on the tail call case, so why not aim for all_tail_calls?

& why the special case of only describing the first call site for any given function - I mean, it's a space saving, but is that sustainable (if so, are you thinking about proposing a DWARF change to support this implementation choice?)? If not, what's the benefit in having that feature/quirk in the short term?

(also, in general: what's your use case for this feature? It does seem like a rather expensive feature (in terms of debug info size) & I've not, myself, encountered particular uses/need for it as yet)


https://reviews.llvm.org/D49887





More information about the llvm-commits mailing list