[PATCH] D49700: [LLD] [COFF] Treat .xdata/.pdata$<sym> as implicitly associative to <sym> for MinGW

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 21:28:11 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D49700#1177509, @rnk wrote:

> In https://reviews.llvm.org/D49700#1177490, @rnk wrote:
>
> > We should try to make it faster. We don't want to hash every symbol we ever add, only the prevailing comdat ones. This will probably save a large number of hash table insertions, because oftentimes most comdat function definitions will be redundant and get discarded.
>
>
> Uh, I guess ignore that. I see your changes to do that now.


Yes, I tried implementing all those suggestions.  Do you think the performance hit (limited to the mingw case) is tolerable now?


https://reviews.llvm.org/D49700





More information about the llvm-commits mailing list