[PATCH] D49880: [MachineOutliner] Clean up subtarget handling.

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 15:58:59 PDT 2018


paquette accepted this revision.
paquette added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/CodeGen/MachineOutliner.cpp:979
+    // Arbitrarily choose a TII from the first candidate.
+    // FIXME: Should getOutliningCandidateInfo move to TargetMachine?
+    const TargetInstrInfo *TII =
----------------
I think this sounds reasonable. TII seems like the wrong place for a lot of the outliner hooks at this point, since a good portion of them don't really have much to do with //instructions// anymore.


Repository:
  rL LLVM

https://reviews.llvm.org/D49880





More information about the llvm-commits mailing list