[PATCH] D49877: ELF: Make --print-icf-sections output deterministic.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 15:12:48 PDT 2018


pcc created this revision.
pcc added reviewers: ruiu, grimar.
Herald added subscribers: mgrang, arichardson, emaste.
Herald added a reviewer: espindola.

The icf-safe.s test currently fails on 32-bit platforms because it uses
the --print-icf-sections flag and depends on the output appearing in
a specific order. However, this flag causes the output to depend on
the order of the sections in the Sections array, which depends on the
hash values returned from hash_combine, which happen to be different
for that test between 32-bit and 64-bit platforms.

This change makes the output deterministic by textually sorting the
printed messages.


Repository:
  rL LLVM

https://reviews.llvm.org/D49877

Files:
  lld/ELF/ICF.cpp
  lld/test/ELF/icf-safe.s
  lld/test/ELF/print-icf.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49877.157587.patch
Type: text/x-patch
Size: 7563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180726/433d43d4/attachment.bin>


More information about the llvm-commits mailing list