[PATCH] D49700: [LLD] [COFF] Treat .xdata/.pdata$<sym> as implicitly associative to <sym> for MinGW

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 14:53:45 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D49700#1177324, @mstorsjo wrote:

> Oh, indeed - sorry for not testing it thoroughly enough myself to realize this, and kudos to you for being thorough.


Thanks!

> It's surprising that this didn't work, but I'm not interested enough in the specifics to dive in the binutils source to figure out why it doesn't.

I gave it a try, but I didn't succeed.

> I guess that some form of this patch is what we need to go with then?

I think we might, because anyone using libstdc++ compiled with gcc on mingw is going to be linking gcc-produced object files. That fourth case that we wanted to rule out might be more important than we think.


https://reviews.llvm.org/D49700





More information about the llvm-commits mailing list