[PATCH] D49630: [MS Demangler] Demangle data member pointers

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:594
+  // emit something like "int (*x)(int)".)
+  if (Pointee->Prim == PrimTy::Function || Pointee->Prim == PrimTy::Array)
+    OS << "(";
----------------
majnemer wrote:
> Nit: Might wanna factor this condition into a little helper to ensure that pre and post are consistent.
I've done this in a followup patch which I plan to apply after I submit the member function pointer patch, since there are some other changes that make sense to do at the same time such as moving the calling convention inside the parens.


https://reviews.llvm.org/D49630