[PATCH] D49467: Fix inconsistency with/without debug information (-g)

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 10:44:00 PDT 2018


probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D49467#1176829, @jeroen.dobbelaere wrote:

> Reassembled to reset the debug id's


Oh nice!  I wasn't aware of that trick.

The other thing we like in debug-info tests, is to reduce the function attributes as much as possible.  I suspect you can eliminate `attributes #1` and instead have `@foobar` use `#0`.  Do that and LGTM.


https://reviews.llvm.org/D49467





More information about the llvm-commits mailing list