[PATCH] D48959: [compiler-rt][ubsan] Implicit Cast Sanitizer - integer truncation - compiler-rt part

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab accepted this revision.
filcab added a comment.

I have a nit I'd like to see addressed, otherwise LGTM.



================
Comment at: test/ubsan/TestCases/ImplicitCast/integer-truncation.cpp:1
+// RUN: %clangxx -fsanitize=implicit-integer-truncation %s -o %t && %run %t 2>&1 | FileCheck %s --check-prefixes=CHECK
+
----------------
Is this the exact same as the other test? If so, please merge both and have two run lines, one for C, one for C++. If there's *any* difference, then it might be better to have the tests as you have them now.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D48959