[PATCH] D49839: [AArch64][ARM] Armv8.2-A: Add the Floating Point Multiplication Variants

Bernard Ogden via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 02:52:16 PDT 2018


bogden requested changes to this revision.
bogden added a comment.
This revision now requires changes to proceed.

Until we define a separate feature for these instructions, they should be predicated on HasV8_4a rather than HasV8_2A. Until v8.4-A they're optional even for CPUs that have HasFullFP16. Current v8.2-A Cortex CPUs, for example, do not support these instructions.

With that change it's probably fine as a part of the v8.4-A support, but I haven't reviewed the rest of it yet.


https://reviews.llvm.org/D49839





More information about the llvm-commits mailing list