[PATCH] D49720: [ARM] Fix over-alignment in arguments that are HA of 128-bit vectors

Petr Pavlu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 26 01:17:38 PDT 2018


petpav01 added a comment.

Thanks for having a look at this patch.



================
Comment at: lib/Target/ARM/ARMCallingConv.h:279
     // we'll be allocating a bunch of i32 slots).
-    Align = Size;
+    Align = std::min(Align, Size);
   }
----------------
efriedma wrote:
> Could you hoist the `std::min(Align, Size)` out of the loop so it's clear it isn't changing every iteration?
Updated.


https://reviews.llvm.org/D49720





More information about the llvm-commits mailing list