[PATCH] D49578: [libFuzzer] Handle unstable edges by poisoning unstable edges

Kyungtak Woo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 17:47:37 PDT 2018


kevinwkt marked an inline comment as done.
kevinwkt added inline comments.


================
Comment at: lib/fuzzer/FuzzerTracePC.cpp:91
+      NumNewUnstableEdges++;
+    UnstableCounters[UnstableIdx].IsUnstable = true;
+    if (UnstableMode == ZeroUnstable)
----------------
Dor1s wrote:
> Can you move this to line 89 please, and then have `switch (UnstableMode)` ? That way it would be slightly more readable and straightforward.
We are supposed to look for the amount of New Unstable Edges.
The way we do this is check if has already been marked as unstable before.
This is also the reason UnstableCounters[UnstableIdx].IsUnstable = true happens after the check.

This bug is now fixed.


https://reviews.llvm.org/D49578





More information about the llvm-commits mailing list