[PATCH] D49514: [compiler-rt] [builtins] Add logb/logbf/logbl methods to compiler-rt to avoid libm dependencies when possible.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/builtins/divxc3.c:16
 
+#define QUAD_PRECISION
+#include "fp_lib.h"
----------------
Could you use a define that isn't QUAD_PRECISION here?  Or just skip changing this file for now?  This is the x86 80-bit long double.


================
Comment at: lib/builtins/ppc/divtc3.c:8
+// Use DOUBLE_PRECISION because the soft-fp method we use is logb (on the upper
+// half of the long doubles), even though this file defines QUAD_PRECISION
+// methods.
----------------
Please change the comment so it doesn't refer to QUAD_PRECISION; that's specifically an IEEE 128-bit float, which isn't relevant here.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49514