[PATCH] D48967: [Dominators] Convert existing passes and utils to use the DomTreeUpdater class

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 11:29:18 PDT 2018


kuhar added a comment.

Thanks for the changes, Chijun!

@brzycki Can you please run run you test suites on this patch and confirm you don't see any new regressions? Chijun has only 2 weeks left until his GSoC and it would be best commit this as soon as possible, unless we discover some problems. Right now, like mentioned above, the patch is functionally equivalent to DDT and shouldn't cause any disruption.

Chijun developed 2 alternative abstractions that make the update code much cleaner in JT, but there won't be enough time to fully test it and commit by the end of his internship. Because of that, we decided to first be done with the transition to the unified interface which is the main artifact of his project.


https://reviews.llvm.org/D48967





More information about the llvm-commits mailing list