[PATCH] D49676: [DWARF] support for .debug_addr (consumer)

Victor Leschuk via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 25 01:15:54 PDT 2018


vleschuk added a comment.

In https://reviews.llvm.org/D49676#1173164, @jhenderson wrote:

> Not specific to your change, but I noticed that a lot of the DWARFContext code uses 32-bit offsets. Would it not make sense where we are writing new stuff, to use 64-bit offsets, since DWARF does support this?


I agree, but this requires refactoring of existing code first: for example at least DataExtractor should be able to work with 64bit offset. I'd prefer not to change it in this revision.


Repository:
  rL LLVM

https://reviews.llvm.org/D49676





More information about the llvm-commits mailing list