[PATCH] D49447: Add an option to specify function name when view/print CFG

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 22:10:59 PDT 2018


eraman accepted this revision.
eraman added a comment.
This revision is now accepted and ready to land.

LGTM with a change to the option description .



================
Comment at: lib/Analysis/CFGPrinter.cpp:27
+    "cfg-func-name", cl::Hidden,
+    cl::desc("The option to specify the name (or a substring of)"
+             " of the function whose CFG is viewed/printed."));
----------------
The description string doesn't need to have "The option to specify ...".  Instead "Name of the function (or its substring) whose..." looks better to me.


https://reviews.llvm.org/D49447





More information about the llvm-commits mailing list