[PATCH] D49383: [cfi-verify] Add an option to treat calls to a specified function as traps.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 17:03:01 PDT 2018


pcc added inline comments.


================
Comment at: tools/llvm-cfi-verify/lib/FileAnalysis.cpp:55
 
+static cl::opt<std::string> TrapFunction(
+    "trap-function",
----------------
Since we know what all of the names of the "trap functions" are, does this really need to be a flag?

Also, `__cfi_slowpath` technically isn't a trap function so maybe there's a better name for this concept.


Repository:
  rL LLVM

https://reviews.llvm.org/D49383





More information about the llvm-commits mailing list