[PATCH] D49764: Simplify ObjFile::createDefined().

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 16:24:17 PDT 2018


ruiu added inline comments.


================
Comment at: lld/COFF/InputFiles.cpp:277
       if (Def->Selection == IMAGE_COMDAT_SELECT_ASSOCIATIVE)
         readAssociativeDefinition(Sym, Def);
     Symbols[I] = createRegular(Sym);
----------------
pcc wrote:
> Since this is now the only caller you could inline the body here.
I tried that but the indentation of the new code looked too deep, so I'd like to keep it as-is.


https://reviews.llvm.org/D49764





More information about the llvm-commits mailing list