[PATCH] D49730: Don't filter test-critical calls out of xray data

[Dean Michael Berris via Phabricator via llvm-commits]

dberris accepted this revision.
dberris added a comment.

LGTM -- thanks, @jmorse!



================
Comment at: test/xray/TestCases/Posix/fork_basic_logging.cc:4-5
 // RUN: rm -f fork-basic-logging-test-*
 // RUN: XRAY_OPTIONS="patch_premain=true xray_logfile_base=fork-basic-logging-test- \
-// RUN:     xray_mode=xray-basic verbosity=1" \
+// RUN:     xray_mode=xray-basic verbosity=1 xray_naive_log_func_duration_threshold_us=0" \
 // RUN:     %run %t 2>&1 | FileCheck %s
----------------
nit: This is the deprecated way of doing this, I suggest using a the XRay Basic Mode environment variable instead. Something like:

```
// RUN: XRAY_OPTIONS=... \
// RUN: XRAY_BASIC_OPTIONS=func_duration_threshold_us=0 \
// RUN:     %run %t 2>&1 | FileCheck %s
```

Not urgent to change though, I can do a pass later when we fully remove these from the main `XRAY_OPTIONS` environment variables.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49730