[PATCH] D45123: [CodeView] Emit function options for subprogram and member functions

[Hui Huang via Phabricator via llvm-commits]

Hui added inline comments.


================
Comment at: CodeGen/AsmPrinter/CodeViewDebug.cpp:373
+  // DISubroutineType is unnamed. Use DISubprogram's i.e. SPName in comparison.
+  if (ClassTy && !isTrivial(ClassTy) && SPName == ClassTy->getName()) {
+    FO |= FunctionOptions::Constructor;
----------------
rnk wrote:
> For constructors, what's the purpose of checking if the class is trivial?
It is observed that MSVC does not emit FunctionOptions::Constructor for a trivial ctor. Checking triviality of ctor is to conform with MSVC.


Repository:
  rL LLVM

https://reviews.llvm.org/D45123