[PATCH] D49700: [LLD] [COFF] Treat .xdata/.pdata$<sym> as implicitly associative to <sym> for MinGW

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 14:50:56 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D49700#1174138, @ruiu wrote:

> Yeah, I understand your situation. I wanted to share my concern with you (or anyone who add new code there) because even to me they are now hard to understand. Let me quickly take a look at this to see if we can actually improve it.


I understand your concern as well, for the evergrowing complexity, and especially when adding things that aren't quite according to any spec or so (i.e. hacks). Luckily this project at least has pretty decent tests, compared to many other codebases...

In any case; if we don't care too much for compatibility with object files built by GCC, and if @rnk thinks https://reviews.llvm.org/D49757 is fine, we could also drop this one.


https://reviews.llvm.org/D49700





More information about the llvm-commits mailing list