[PATCH] D49700: [LLD] [COFF] Treat .xdata/.pdata$<sym> as implicitly associative to <sym> for MinGW

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 14:35:55 PDT 2018


ruiu added a comment.

`initializeSymbols` and `createDefined` were originally much simpler than they are now. They are becoming complicated gradually over time. Due to the length of these functions (they are a bit too long to my taste) and the lack of comments (for example, what does `Prevailing` means?), they are probably hard to read for newcomers. Can you simplify the code and add an explanation as a comment before adding more code there? I believe the code can be improved.


https://reviews.llvm.org/D49700





More information about the llvm-commits mailing list