[PATCH] D49751: Add maybe-unused attribute to a variable.

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 13:19:25 PDT 2018


srhines added a comment.

Definitely deal with the submodule stuff. We don't want a new file checked in for tools/clang.

In the commit message did you mean "unused-but-set" instead of "unused-by-set"?



================
Comment at: lib/IR/SafepointIRVerifier.cpp:87
     const BasicBlock* BB = PN->getParent();
+    [[maybe_unused]]
     bool Listed = false;
----------------
Did you run clang-format on this? I think it belongs on the same line for LLVM coding style.


Repository:
  rL LLVM

https://reviews.llvm.org/D49751





More information about the llvm-commits mailing list