[PATCH] D49731: [Dominators] Assert if there is modification to DelBB while it is awaiting deletion

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 08:44:43 PDT 2018


kuhar added inline comments.


================
Comment at: lib/IR/DomTreeUpdater.cpp:141
+           isa<UnreachableInst>(BB->getTerminator()) &&
+           "DelBB has been modified while awaiting deletion.");
     BB->removeFromParent();
----------------
This deserves a comment -- it's not clear why such a block would have exactly one instruction that is UnreachableInst


Repository:
  rL LLVM

https://reviews.llvm.org/D49731





More information about the llvm-commits mailing list