[PATCH] D49679: [DebugInfo] Have custom DWARFDie:: reverse_iterator

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 07:45:43 PDT 2018


JDevlieghere updated this revision to Diff 157035.
JDevlieghere added a comment.

Address Pavel's feedback:

- Don't clutter std namespace.
- Don't redefine iterator traits.
- Add test cases that checks bidirectional aspect of both iterators.
- Fix `operator bool()` to check AtEnd.


https://reviews.llvm.org/D49679

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDie.h
  llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49679.157035.patch
Type: text/x-patch
Size: 6306 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180724/c770d151/attachment.bin>


More information about the llvm-commits mailing list