[PATCH] D49611: [X86] Improved sched models for X86 SHLD/SHRD* instructions

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: lib/Target/X86/X86InstrShiftRotate.td:655
 
-let Uses = [CL] in {
+let Uses = [CL], SchedRW = [WriteSHDrrc] in {
 def SHLD16rrCL : I<0xA5, MRMDestReg, (outs GR16:$dst),
----------------
Nitpicking: i wish there was some documented naming scheme.
E.g., why is this `c` instead of `CL`?


================
Comment at: lib/Target/X86/X86InstrShiftRotate.td:686
                     TB;
 }
 
----------------
```
} // SchedRW
```


================
Comment at: lib/Target/X86/X86InstrShiftRotate.td:731-732
                  TB;
 }
 } // Constraints = "$src = $dst", SchedRW
 
----------------
```
} // SchedRW
} // Constraints = "$src = $dst"
```


================
Comment at: lib/Target/X86/X86InstrShiftRotate.td:761
                       addr:$dst)]>, TB;
 }
 
----------------
```
} // SchedRW
```


https://reviews.llvm.org/D49611