[llvm] r337794 - AMDGPU/GlobalISel: Remove unnecessary legality constraint for G_EXTRACT
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 23 18:43:49 PDT 2018
Author: tstellar
Date: Mon Jul 23 18:43:49 2018
New Revision: 337794
URL: http://llvm.org/viewvc/llvm-project?rev=337794&view=rev
Log:
AMDGPU/GlobalISel: Remove unnecessary legality constraint for G_EXTRACT
Summary:
We were marking G_EXTRACT operations unsupported if the output type
was larger than the input type. I don't see how this could ever actually
happen, so I dropped the constraint. Doing this makes it possible to
reuse the same legality code for G_INSERT.
Reviewers: arsenm
Reviewed By: arsenm
Subscribers: kzhuravl, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, llvm-commits
Differential Revision: https://reviews.llvm.org/D49600
Modified:
llvm/trunk/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
Modified: llvm/trunk/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp?rev=337794&r1=337793&r2=337794&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp (original)
+++ llvm/trunk/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp Mon Jul 23 18:43:49 2018
@@ -173,9 +173,6 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo
// FIXME: Doesn't handle extract of illegal sizes.
getActionDefinitionsBuilder(G_EXTRACT)
- .unsupportedIf([=](const LegalityQuery &Query) {
- return Query.Types[0].getSizeInBits() >= Query.Types[1].getSizeInBits();
- })
.legalIf([=](const LegalityQuery &Query) {
const LLT &Ty0 = Query.Types[0];
const LLT &Ty1 = Query.Types[1];
More information about the llvm-commits
mailing list