[PATCH] D49712: [docker] Fix LLVM_EXTERNAL_PROJECTS cmake variable value

Azharuddin Mohammed via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 18:35:19 PDT 2018


azharudd created this revision.
azharudd added a reviewer: ilya-biryukov.

LLVM_ENABLE_PROJECTS expects a semicolon separated project list.

Fixes PR38158.


Repository:
  rL LLVM

https://reviews.llvm.org/D49712

Files:
  utils/docker/build_docker_image.sh


Index: utils/docker/build_docker_image.sh
===================================================================
--- utils/docker/build_docker_image.sh
+++ utils/docker/build_docker_image.sh
@@ -117,7 +117,7 @@
 
       CHECKOUT_ARGS="$CHECKOUT_ARGS $1 $PROJ"
       if [ "$PROJ" != "clang-tools-extra" ]; then
-        CMAKE_ENABLED_PROJECTS="$CMAKE_ENABLED_PROJECTS:$PROJ"
+        CMAKE_ENABLED_PROJECTS="$CMAKE_ENABLED_PROJECTS;$PROJ"
       fi
 
       shift 2
@@ -142,7 +142,7 @@
 
 
 if [ "$CMAKE_ENABLED_PROJECTS" != "" ]; then
-  # Remove the leading ':' character.
+  # Remove the leading ';' character.
   CMAKE_ENABLED_PROJECTS="${CMAKE_ENABLED_PROJECTS:1}"
 
   if [[ $SEEN_CMAKE_ARGS -eq 0 ]]; then


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49712.156951.patch
Type: text/x-patch
Size: 710 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180724/87f14b99/attachment.bin>


More information about the llvm-commits mailing list