[PATCH] D48807: Add llvm::Any

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 18:19:59 PDT 2018


dblaikie added inline comments.


================
Comment at: llvm/unittests/ADT/AnyTest.cpp:114-115
+  // in the process.
+  EXPECT_EQ(8, llvm::any_cast<int>(std::move(E)));
+  EXPECT_TRUE(E.hasValue());
+
----------------
zturner wrote:
> dblaikie wrote:
> > Is there a test (didn't spot it) that demonstrates that the result of llvm::any_cast on an rvalue Any is the value moved-from the the Any, and that the Any contains the original move-from?
> Is the newly added test in line with what you had in mind?
Yeah, looks good!


Repository:
  rL LLVM

https://reviews.llvm.org/D48807





More information about the llvm-commits mailing list