[PATCH] D49707: [tsan] Fix crash in objc_sync_enter/objc_sync_exit when using an Obj-C tagged pointer

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: lib/tsan/rtl/tsan_interceptors_mac.cc:297
 
+bool IsTaggedPointer(void *obj) {
+  const uptr kPossibleTaggedBits = 0x8000000000000001ull;
----------------
george.karpenkov wrote:
> can we have a short docstring for both functions? Also, `isTaggedObjCPointer`?
> Also, `isTaggedObjCPointer`?
In (almost) all of TSan, private functions starts with an uppercase letter. Let's not try to change style with this patch.


https://reviews.llvm.org/D49707