[PATCH] D49138: [LTO] Handle __imp_ (dllimport) symbols consistently with lld

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 11:57:31 PDT 2018


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM

Sorry, I reviewed this and left one comment but I forgot to send it. Aside from that, this looks good.



================
Comment at: lib/LTO/LTO.cpp:528
                        LTOInfo->IsThinLTO ? ThinLTO.ModuleMap.size() + 1 : 0,
-                       LTOInfo->HasSummary);
+                       LTOInfo->HasSummary, Triple(Input.getTargetTriple()));
 
----------------
You don't need to pass a triple here, you can get it from `RegularLTO.CombinedModule->getTargetTriple()`.


Repository:
  rL LLVM

https://reviews.llvm.org/D49138





More information about the llvm-commits mailing list