[PATCH] D49633: [CStringSYntaxChecker] Improvements of strlcpy check

George Karpenkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 11:03:03 PDT 2018


george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp:166
     uint64_t ILRawVal = IL->getValue().getZExtValue();
+    // case when there is pointer arithmetic on the destination buffer
+    // especially when we offset from the base decreasing the
----------------
nit: sentence case, newline before the comment block, dot after the end of the sentence.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49633





More information about the llvm-commits mailing list