[PATCH] D49681: OpChain has subclasses, so add a virtual destructor.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 10:33:46 PDT 2018


rupprecht created this revision.
Herald added a reviewer: javed.absar.
Herald added a subscriber: llvm-commits.

OpChain has subclasses, so add a virtual destructor.

This fixes an issue when deleting subclasses of OpChain (see MatchSMLAD() specifically) in r337701.


Repository:
  rL LLVM

https://reviews.llvm.org/D49681

Files:
  lib/Target/ARM/ARMParallelDSP.cpp


Index: lib/Target/ARM/ARMParallelDSP.cpp
===================================================================
--- lib/Target/ARM/ARMParallelDSP.cpp
+++ lib/Target/ARM/ARMParallelDSP.cpp
@@ -64,6 +64,7 @@
     bool          ReadOnly = true;
 
     OpChain(Instruction *I, ValueList &vl) : Root(I), AllValues(vl) { }
+    virtual ~OpChain() = default;
 
     void SetMemoryLocations() {
       const auto Size = MemoryLocation::UnknownSize;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49681.156818.patch
Type: text/x-patch
Size: 438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180723/c890592c/attachment.bin>


More information about the llvm-commits mailing list