[PATCH] D48815: [VPlan] Introduce VPlan-based dominator analysis.

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Please hold off committing a few days, in case other people have additional comments.



================
Comment at: lib/Transforms/Vectorize/LoopVectorize.cpp:7062
   // Build hierarchical CFG
-  VPlanHCFGBuilder HCFGBuilder(OrigLoop, LI);
-  HCFGBuilder.buildHierarchicalCFG(*Plan.get());
+  VPlanHCFGBuilder HCFGBuilder(OrigLoop, LI, *Plan.get());
+  HCFGBuilder.buildHierarchicalCFG();
----------------
nit: Just *Plan should be enough.


================
Comment at: unittests/Transforms/Vectorize/VPlanTestBase.h:54
+    VPlanHCFGBuilder HCFGBuilder(LI->getLoopFor(LoopHeader), LI.get(),
+                                 *Plan.get());
+    HCFGBuilder.buildHierarchicalCFG();
----------------
nit: just *Plan should work


================
Comment at: unittests/Transforms/Vectorize/VPlanTestBase.h:65
+    VPlanHCFGBuilder HCFGBuilder(LI->getLoopFor(LoopHeader), LI.get(),
+                                 *Plan.get());
+    VPRegionBlock *TopRegion = HCFGBuilder.buildPlainCFG();
----------------
nit: just *Plan


https://reviews.llvm.org/D48815