[PATCH] D49630: [MS Demangler] Demangle data member pointers

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

a few nits (haven't looked at substance):



================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:302
+    return false;
+    break;
+  case 'P':
----------------
no break after return


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:307
+  case 'S':
+    // These 4 values indicate some kind of pointer, but we still dont' know
+    // what.
----------------
don't


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:318
+    assert(MangledName.front() == '6' || MangledName.front() == '8');
+    return (MangledName.front() == '8') ? true : false;
+  }
----------------
just `return MangledName.front() == '8';`, ternary does nothing


https://reviews.llvm.org/D49630