[PATCH] D49626: ELF: Read address significance tables with --icf=all.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 18:43:04 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Driver.cpp:1243
+    if (D->Section)
+      // We don't need to keep text sections unique under --icf=all if they are
+      // address-significant.
----------------
if -> even if?


https://reviews.llvm.org/D49626





More information about the llvm-commits mailing list