[PATCH] D47114: [FileCheck] Implement -v and -vv for tracing matches

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D47114#1170688, @george.karpenkov wrote:

> @jdenny Right, I see now!
>  So my point was that instead of having many different "better-debug" flags, maybe it's better to have one, and just call it "VERBOSE", or similar.


Ah.  The desire to have some way at all to pass various flags through ninja to lit and FileCheck resonated more with me, so I responded to that part only.  But I agree that succinctness might be helpful too, and it sounds like you want to achieve that through numbered verbosity levels.

An environment variable should probably have a LIT_ or FILECHECK_ prefix, right?  If you don't want to have to specify both, perhaps LIT_VERBOSE would tell lit to also set FILECHECK_VERBOSE.

At what verbosity levels would each of FileCheck's -v, -vv, and --dump-input-on-failure (any other flags) be?  I suppose the order is -v, --dump-input-on-failure, and then -vv.  If that makes sense, then why not rename the latter two to -vv and -vvv?  The only trouble is if someone wants -vvv except he finds the large --dump-input-on-failure very annoying.

> Passing custom flags to LIT seems like a rather unlikely scenario.

I'm not sure what you mean by custom, but there's already LIT_FILTER/--filter (and other test selection flags) and -v/-vv (and other output format flags).


Repository:
  rL LLVM

https://reviews.llvm.org/D47114