[PATCH] D47114: [FileCheck] Implement -v and -vv for tracing matches

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D47114#1170522, @george.karpenkov wrote:

> > lit runs only
>
> Yeah, that's why I have originally created the LIT_FILTER variable.
>
> > LIT_FLAGS would work too, right?
>
> Does this variable exist? I've just grepped through LIT source and have not seen it.


We're miscommunicating.  I'm proposing LIT_FLAGS now, and I thought you were arguing it wouldn't be seen by lit because it was invoked via ninja, so I mentioned LIT_FILTER as an example where an environment variable passes through just fine.  I didn't realize you were the author of LIT_FILTER.

To clarify, I'm proposing that LIT_FLAGS and FILECHECK_FLAGS environment variables would be a general way to pass flags to lit and FileCheck so that we don't have to keep creating new environment variables.

>> I'd agree, unless a use case we're trying to address is overriding what was specified on the command line
> 
> I think it should be other way around: "normal" command line invocation should not have any extra flags, then environment variable (e.g. BOT config) modifies that, and then if the test authors no semantics better (e.g. it operates over HUUUUGE inputs) they can override the environment variable with flags.

I agree that's probably best.  If we find other use cases, we can handle those later.


Repository:
  rL LLVM

https://reviews.llvm.org/D47114