[PATCH] D47114: [FileCheck] Implement -v and -vv for tracing matches

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In https://reviews.llvm.org/D47114#1170460, @george.karpenkov wrote:

> @jdenny The precedence should always be given to command line flags, since that's what was specified explicitly vs. lingering in the environment.


Normally I'd agree, unless a use case we're trying to address is overriding what was specified on the command line.  In that case, a _FORCE suffix and a warning might be best.

> The problem is most developers don't invoke LIT directly, they invoke a ninja target, e.g. "ninja check-clang".
>  In such a pattern there's no way to pass LIT flags through.

If I run

  $ LIT_FILTER=dtls_test ninja check-msan

lit runs only

  MemorySanitizer-X86_64 :: dtls_test.c
  MemorySanitizer-lld-X86_64 :: dtls_test.c

LIT_FLAGS would work too, right?

I'm on linux.  Is there a problem on other platforms?


Repository:
  rL LLVM

https://reviews.llvm.org/D47114