[PATCH] D49328: [FileCheck] Provide an option for FileCheck to dump original input to stderr on failure

George Karpenkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 13:25:53 PDT 2018


george.karpenkov added a comment.

@dblaikie One thing where we could get unexpected behavior is when the environment variable is enabled, but the test does "not FileCheck",
thereby reversing the expected output.
However, I have only seen that done in `test/MC/Mips`, not in Clang at all, and arguably it's a bad design pattern with double negation,
where using `-NOT` directives was a way to go.


https://reviews.llvm.org/D49328





More information about the llvm-commits mailing list