[PATCH] D49605: AMDGPU: Fix implementation of isCanonicalized

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 12:37:15 PDT 2018


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:6859-6860
+      // No flushing required, so we just need to care about snans.
+      return isKnownNeverSNan(DAG, Op.getOperand(0)) &&
+             isKnownNeverSNan(DAG, Op.getOperand(1));
+    }
----------------
I'm not sure if this is right. I'm not sure if the nan needs to be a canonicalized nan with the payload bits cleared if the input had them


https://reviews.llvm.org/D49605





More information about the llvm-commits mailing list