[PATCH] D49328: [FileCheck] Provide an option for FileCheck to dump original input to stderr on failure

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 11:27:31 PDT 2018


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good to me (maybe add a negative test case to ensure the full text is not dumped when neither the environment variable or command line parameter is used - I imagine most/many FileCheck test cases might be silently passing even if this behavior was enabled by default?). Also maybe the command line argument version of the test should specifically unset the environment variable - to make sure the test is testing what's intended even in cases where someone is setting the env variable on by default (some users may do this, or buildbots)? (worth checking that all the tests pass even if you turn this option on by default - maybe some FileCheck self-tests may fail when this unexpected output turns up?)


https://reviews.llvm.org/D49328





More information about the llvm-commits mailing list