[PATCH] D49467: Fix inconsistency with/without debug information (-g)

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Please rename the new test to simply 'codegenprepare-and-debug.ll` (the convention of a date on the test name is obsolete, we don't do that for new tests anymore).



================
Comment at: llvm/test/Other/2018-07-20-codegenprepare-and-debug.ll:3
+; RUN: opt -strip-debug -codegenprepare -S < %s | FileCheck %s
+
+; In it's current state, CodeGenPrepare should not optimize empty blocks after a switch
----------------
It would be good to be explicit about the X86 dependency:
`; REQUIRES: x86-registered-target`



================
Comment at: llvm/test/Other/2018-07-20-codegenprepare-and-debug.ll:4
+
+; In it's current state, CodeGenPrepare should not optimize empty blocks after a switch
+; (See CodeGenPrepare::isMergingEmptyBlockProfitable)
----------------
`it's` should be `its` here.


https://reviews.llvm.org/D49467