[PATCH] D49588: [CStringSyntaxChecker] Fix build bot builds != x86 archs
David CARLIER via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 19 21:36:31 PDT 2018
devnexen created this revision.
devnexen added reviewers: dexonsmith, NoQ, ddcc, george.karpenkov.
Herald added subscribers: Sanitizers, llvm-commits.
Adding more unit tests
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D49588
Files:
lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
test/Analysis/cstring-syntax.c
Index: test/Analysis/cstring-syntax.c
===================================================================
--- test/Analysis/cstring-syntax.c
+++ test/Analysis/cstring-syntax.c
@@ -1,4 +1,6 @@
// RUN: %clang_analyze_cc1 -analyzer-checker=unix.cstring.BadSizeArg -analyzer-store=region -Wno-strncat-size -Wno-strlcpy-strlcat-size -Wno-sizeof-array-argument -Wno-sizeof-pointer-memaccess -verify %s
+// RUN: %clang_analyze_cc1 -triple armv7-a15-linux -analyzer-checker=unix.cstring.BadSizeArg -analyzer-store=region -Wno-strncat-size -Wno-strlcpy-strlcat-size -Wno-sizeof-array-argument -Wno-sizeof-pointer-memaccess -verify %s
+// RUN: %clang_analyze_cc1 -triple aarch64_be-none-linux-gnu -analyzer-checker=unix.cstring.BadSizeArg -analyzer-store=region -Wno-strncat-size -Wno-strlcpy-strlcat-size -Wno-sizeof-array-argument -Wno-sizeof-pointer-memaccess -verify %s
typedef __SIZE_TYPE__ size_t;
char *strncat(char *, const char *, size_t);
Index: lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
===================================================================
--- lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
+++ lib/StaticAnalyzer/Checkers/CStringSyntaxChecker.cpp
@@ -163,8 +163,7 @@
uint64_t ILRawVal = IL->getValue().getZExtValue();
if (const auto *Buffer = dyn_cast<ConstantArrayType>(DstArgDecl->getType())) {
ASTContext &C = BR.getContext();
- uint64_t Usize = C.getTypeSizeInChars(DstArg->getType()).getQuantity();
- uint64_t BufferLen = BR.getContext().getTypeSize(Buffer) / Usize;
+ uint64_t BufferLen = C.getTypeSize(Buffer) / 8;
if (BufferLen < ILRawVal)
return true;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49588.156427.patch
Type: text/x-patch
Size: 1656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180720/b6536469/attachment-0001.bin>
More information about the llvm-commits
mailing list