[PATCH] D49561: AMDGPU: Try to make isKnownNeverSNan more accurate

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 16:09:46 PDT 2018


rampitec added a comment.

In https://reviews.llvm.org/D49561#1168791, @arsenm wrote:

> In https://reviews.llvm.org/D49561#1168643, @rampitec wrote:
>
> > I would tend to say isKnownNeverSNan here basically tells not that it cannot be sNaN, but rather that we do not care even if it is. At least we should not care if FP exceptions are off.
>
>
> Except that's not true since there can be sNaNs can be loaded, so even if exceptions aren't handled they need to be dealt with


Do you mean we shall quiet snans with an fmin/fmax even if exception handling is off? My understanding was different. In fact I thought we can completely ignore them with say fast math.


https://reviews.llvm.org/D49561





More information about the llvm-commits mailing list