[PATCH] D49534: Handle the lack of a symbol table correctly.

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 14:57:44 PDT 2018


alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:653
   Config.OutputFilename =
-      InputArgs.getLastArgValue(STRIP_output, Positional[0]);
+      InputArgs.getLastArgValue(STRIP_output, Positional[Positional.size()-1]);
 
----------------
if i understand correctly, this line should be reverted back as discussed on the other diff + remove the lines 45-49 in the test.

the other change (line 418 + tests) looks fine to me


Repository:
  rL LLVM

https://reviews.llvm.org/D49534





More information about the llvm-commits mailing list