[PATCH] D49493: [DebugInfo] Reduce debug_str_offsets section size

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: test/DebugInfo/X86/string-offsets-table-order.ll:28-31
+; CHECK: 0x00000008: 00000000 "foo.dwo"
+; CHECK: 0x0000000c: [[X3]] "X3"
+; CHECK: 0x00000010: [[X2]] "X2"
+; CHECK: 0x00000014: [[X1]] "X1"
----------------
Rather than hardcoding these particular byte offset prefixes (honestly, probably not necessary for the dumper to dump these except in the most verbose modes maybe) - but use CHECK-NEXT instead, to ensure these are the only 4 strings (CHECK something at the end to ensure that's the end of the list - though I realize the "contribution size" validates that, but again, probably easier not to check for that specific value (easier to update the test with new strings if it's just checking for the specific elements in a list, without checking offsets, sizes, etc)


Repository:
  rL LLVM

https://reviews.llvm.org/D49493