[PATCH] D49473: [MSan] pull insertShadowCheck() into getShadowOriginPtr(). NFC

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 13:24:00 PDT 2018


eugenis added inline comments.


================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1495
     StoreList.push_back(&I);
+    if (ClCheckAccessAddress)
+      insertShadowCheck(I.getPointerOperand(), &I);
----------------
So all you really need is this chunk, and reordering of materializeStores and materializeChecks? Could you revert the rest of the change then?

I prefer the current, more explicit, way of inserting address checks.


https://reviews.llvm.org/D49473





More information about the llvm-commits mailing list