[PATCH] D49249: [libFuzzer] Use separate test directory for each config

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 19 10:47:42 PDT 2018


jdenny added a comment.

In https://reviews.llvm.org/D49249#1161704, @morehouse wrote:

> The other test configs don't define `config.test_exec_root` at all.  Do we need it?


It seems we don't.  I removed it, and the tests pass.  I'll upload a new patch.

In https://reviews.llvm.org/D49249#1165477, @george.karpenkov wrote:

> @morehouse unit tests for other sanitizers do though.
>  I'm a bit confused on what exactly is happening here,


The same tests were being run for different configs, which thus shared output files.  By setting different directories for different configs, they no longer share output files.

> and why tests pass on other platforms

I haven't explored other platforms.  Do they ever support multiple conflicting configs (like X86_64DefaultLinuxConfig and X86_64LibcxxLinuxConfig)?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49249





More information about the llvm-commits mailing list